Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 16 Holes C Chromatic Harmonica Standard Tuning. #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for 16 Holes C Chromatic Harmonica Standard Tuning. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c2fc82
Update README.md
Ismael-VC Sep 27, 2021
79d78e5
Add 16 Chromatic support.
Ismael-VC Sep 27, 2021
357a9f6
Update harmonica_tablature.qml
Ismael-VC Sep 28, 2021
879be79
Update README.md
Ismael-VC Sep 28, 2021
d6698a6
Update harmonica_tablature.qml
Ismael-VC Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ If you want to have your harmonica added to the it, please contact me, or better


##Convention
* "+" = blow
* "-" = draw
* ' = halfstep bend
* " = whole step bend
* "' = 3 halfsteps bend
* +X? = overblow
* -X? = overdraw
* "<" = slide
* `+4` = blow
* `-4` = draw
* `-3b` = halfstep bend
* `-3bb` = whole step bend
* `-3bbb` = 3 halfsteps bend
* `+6o` = overblow
* `-9o` = overdraw
* `+4s` = slide (chromatic)
* `+1*` = lower register in 16 holes chromatic (1*, 2*, 3*, 4*, 1, 2, 3, 4, 5, 6, 7 , 8, 9 ,10, 11, 12)


Bends, over blow, over draw may be supported if it's the only way to play the note.
If there are two holes for one note, a choice has been made (draw)
Expand Down
21 changes: 20 additions & 1 deletion harmonica_tablature.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ MuseScore {
ListElement { text: "Power Bender (Brendan Power), valved"; tuning: 11 }
ListElement { text: "Power Draw (Brendan Power), valved"; tuning: 12 }
ListElement { text: "Standard Chromatic"; tuning: 4 }
ListElement { text: "16 Hole Standard Chromatic"; tuning: 13}
}
width: 100
onCurrentIndexChanged: {
Expand Down Expand Up @@ -162,7 +163,15 @@ MuseScore {
var standardChromatic = ["+1", '+1s', "-1", "-1s", "+2", "-2", "-2s", "+3", "+3s", "-3", "-3s","-4",
"+4", "+4s", "-5", "-5s", "+6", "-6", "-6s", "+7", "+7s", "-7", "-7s", "-8",
"+8", "+8s", "-9", "-9s", "+10", "-10", "-10s", "+11", "+11s", "-11", "-11s", "-12",
"+12", "+12s", "-12", "-12s" ];
"+12", "+12s", "-12s" ];

var standard16Chromatic = [
"+1*", '+1*s', "-1*", "-1*s", "+2*", "-2*", "-2*s", "+3*", "+3*s", "-3*", "-3*s","-4*",
"+1", '+1s', "-1", "-1s", "+2", "-2", "-2s", "+3", "+3s", "-3", "-3s","-4",
"+4", "+4s", "-5", "-5s", "+6", "-6", "-6s", "+7", "+7s", "-7", "-7s", "-8",
"+8", "+8s", "-9", "-9s", "+10", "-10", "-10s", "+11", "+11s", "-11", "-11s", "-12",
"+12", "+12s", "-12s"
];

var zirkValved = ["+1", "-1b", "-1", "+2b", "+2", "-2", "+3b", "+3", "-3b", "-3", "+4", "-4b",
"-4", "+5b", "+5", "-5b", "-5", "+6", "-6b", "-6", "+7b", "+7", "-7", "+8b",
Expand Down Expand Up @@ -220,12 +229,22 @@ MuseScore {
case 10: tuning = paddyRichter; break;
case 11: tuning = powerBender; break;
case 12: tuning = powerDraw; break;
case 13: tuning = standard16Chromatic; break;
default: tuning = richter; break;
}

var harpkey = keylist.key
console.log("harpkey set to " + keylist.key)

// For 16 Holes Standard C Chromatic
var C3 = 48;
var C4 = 60;
var chromatic16Tuning = 13;

if (harpkey == C4 && harp.tuning == chromatic16Tuning) {
harpkey = C3;
}

for (var i = 0; i < notes.length; i++) {

if ( i > 0 )
Expand Down