Remove the NoteLine element #24993
Open
Remove the NoteLine element #24993
+2
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify: this is not about removing the note achored line, right? There is an I can't see or find any ill effect of this removal |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 1, 2024
Backport of musescore#24993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a little drastic, but as far as I could tell this class has never been used in a release. The note anchored lines in Add > Lines > Note anchored line have simply been a textbase line with its
anchorproperty set toSpanner::Anchor::Note(introduced in 0df85cb).This action briefly created a NoteLine element (a7904c3) until this was reverted less than a month later (ee4b4ea). This happened June-July 2013, after the release of 1.3 (Feb) and before the release of 2.0 (2015).
If anyone has objections, let me know!