fix: gp5 voltas import #24981
Open
fix: gp5 voltas import #24981
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
Sep 30, 2024
alexpavlov96
approved these changes
Sep 30, 2024
|
That It doesn't make sense though, and the failing unit test seems to prove it. There there repeat cound would need to be much higher, 8, as there are that many voltas (ignoring the missing of a volta for the 4th, 5th and 7th round) a 2 is actually enough there, but that last measure neeeds a play count of at least 4 and an end repeat barline. |
mikekirin
force-pushed
the
gp5-voltas-import-m
branch
from
965203a
to
1e6a445
Compare
|
play count needs to be one more that the 1st volta's repeat list length... here (in that unit test) a 2, the default, is perfectly correct |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 30, 2024
Backport of musescore#24981 and fix some clazy warnings, one of which revealed a memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measure with the end repeat barline must have a Play count value that is equal to, the total number of times of playback of this measure + 1 or morehttps://musescore.org/en/handbook/4/voltas#change-playback