Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4.3] Added image and actions to musesound update spec #24974

Open
wants to merge 1 commit into
base: 4.4.3
Choose a base branch
from

Conversation

igorkorsukov
Copy link
Contributor

@igorkorsukov igorkorsukov commented Sep 30, 2024

New spec

    /*
    {
        "version": String,
        "image_url": String,  // it can be base64 data, like "data:image/png;base64,iVBORw0KGgoA......"
        "content": {
            "locale_code": {
                "notes": String,
                "features": [String]
                "action_title": String // title of action button
            }
        },

        // open app or web page url, try in order,
        // like this ["musehub://?from=musescore", "muse-hub://?from=musescore", "https://www.musehub.com"]
        "actions": {
            "windows": [String],
            "macos": [String],
            "linux": [String]
        }
    }
    */

@@ -45,7 +44,7 @@ class IMuseSoundsCheckUpdateService : MODULE_EXPORT_INTERFACE

virtual Progress updateProgress() = 0;

virtual void openMuseHub() = 0;
virtual void openMuseHub(const std::vector<std::string>& actions) = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need it in this interface... Perhaps it was originally intended to be reusable, but with the addition of the actions argument, it's unclear how to use it. We can make it a private method of MuseSoundsCheckUpdateScenario

@@ -78,7 +80,7 @@ StyledDialogView {
Layout.fillWidth: true
Layout.preferredHeight: 186

source: "qrc:/qml/Muse/Update/resources/muse_sounds_promo.png"
//source: "qrc:/qml/Muse/Update/resources/muse_sounds_promo.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants