Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple MIDI out issues #24944

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix multiple MIDI out issues #24944

wants to merge 4 commits into from
+300 −91

Commits on Sep 27, 2024

  1. Make midi input and output work. (Fixing) 

    FluidSequencer: store 16 bit velocity in midi 2.0 note messages.
FluidSynth: explicitely use 7 bit velocity, 14 bit pitch bend and 7bit CC data, automatically scaled down if needed.
midi::Event: Fix midi 2 to 1 conversion details.
macOS Core Midi: Use correct packet length.

Improving MIDI output in FluidSynth / FluidSequencer:
Cleanup hanging notes: Send 'all notes off' and related control reset messages to midi out port.
Midi out channel: Use staff index as midi out channel. Addresses issue musescore#18382 in a simple way.
    @SolfaMode
    SolfaMode committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    cf0d53d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Rewrite logging as suggested by cbjeukendrup.

    @SolfaMode
    SolfaMode committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    9405a78 View commit details
    Browse the repository at this point in the history

  2. Use "MIDI 2.0" checkbox for toggling MIDIEventList vs MIDIPacketList … 

    …code paths.
    @SolfaMode
    SolfaMode committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    34a5517 View commit details
    Browse the repository at this point in the history

  3. Remove destinationProtocolId, because CoreMIDI translates MIDI2.0 <=>… 

    … MIDI 1.0, if necessary.
    @SolfaMode
    SolfaMode committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f696086 View commit details
    Browse the repository at this point in the history