-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #17397: Fully export instrument changes to MusicXML #24932
base: master
Are you sure you want to change the base?
Conversation
Backport of musescore#24932 and fixing some clang watnings
} | ||
m_xml.endElement(); | ||
|
||
writeInstrumentDetails(instrChange->instrument(), m_score->style().styleB(Sid::concertPitch)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using instr
here too, like a few lines down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review! Actually found another thing that lead to invalid MusicXML output. Fixed that one, too.
Backport of musescore#24932 and enable and fix testMultiInstrumentPart3. Also fixing some clang warnings.
5fa298c
to
744d4d2
Compare
const int instNr = muse::value(m_instrMap, instr, -1); | ||
const string longName = instr->nameAsPlainText(); | ||
const string shortName = instr->abbreviatureAsPlainText(); | ||
static const std::wregex acc(L"[♭♯]"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused variable?
33dc07d
to
d6b1fb6
Compare
d6b1fb6
to
5bad6ac
Compare
Backport of musescore#24932 and enable and fix testMultiInstrumentPart3. Also fixing some clang warnings.
Backport of musescore#24932 and enable and fix testMultiInstrumentPart3. Also fixing some clazy warnings.
This PR adds full export of instrument changes to MusicXML support.
Closes #17397.
NB: Import currently doesn't change the instrument name yet, so this has to be adjested for fully working round-trips of import and export.