fermata_duration_fix #24921
Open
fermata_duration_fix #24921
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
commented
Sep 25, 2024
| @@ -579,15 +579,16 @@ void Score::rebuildTempoAndTimeSigMaps(Measure* measure, std::optional<BeatsPerS | |||
| } | |||
| } | |||
| } | |||
| if (!RealIsNull(stretch) && !RealIsNull(stretch)) { | |||
|
|
|||
| if (!RealIsNull(stretch) && !RealIsEqual(stretch, 1.0)) { | |||
There was a problem hiding this comment.
mike-spa
reviewed
Sep 26, 2024
src/engraving/dom/score.cpp
Outdated
| if (segment.next1()) { | ||
| currentSegmentEndTick = segment.next1()->tick(); | ||
| if (const Segment* nextActiveSegment = segment.nextActive()) { | ||
| currentSegmentEndTick = nextActiveSegment->tick(); |
There was a problem hiding this comment.
Ideally, the duration of the fermata should be based on the duration of the ChordRest that the fermata is applied to (fermatas can be voice-specific, so in this case the voice-0 chord). That's often not the same as the duration of the segment itself. This kind of situation is quite common: here the fermata should last 4/4, even if the segment ticks is 1/8.
We can do this later though. For now this looks ok to me
mike-spa
approved these changes
Sep 26, 2024
RomanPudashkin
force-pushed
the
fermata_duration_fix
branch
from
87fbbf7
to
9bfba24
Compare
mike-spa
approved these changes
Sep 26, 2024
…ting fermata duration
RomanPudashkin
force-pushed
the
fermata_duration_fix
branch
from
9bfba24
to
2058077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24852