Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22354 fix midi out velocity and midi mac #24837

Conversation

SolfaMode
Copy link

Resolves: #22354
For a long time the midi output was broken in MuseScore 4. Due to inconsistent use of MIDI 2.0 and MIDI 1.0 data values a midi 1.0 note velocity of 64 would be interpreted in Midi 2.0 as very small and substitued by 1.
The pull request fixes this by small changes in fluid synth event generation and event interpretation code.

Also handling of Midi event lists on the mac, both output and input was not correct. I fixed it as well.
I added some needed utilities and fixed some code in Event type that I noticed was incorrect.

I tested Midi Input and output on the Mac.
I am not sure if the code follows the CodeGuidelines.

  • [x ] I signed the CLA
  • [ x] The title of the PR describes the problem it addresses
  • [ x] Each commit's message describes its purpose and effects, and references the issue it resolves
  • [ x] If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • [ x] There are no unnecessary changes
  • [x ] The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@SolfaMode SolfaMode marked this pull request as draft September 27, 2024 10:53
@SolfaMode
Copy link
Author

This pull request is superseded by:
Fix multiple MIDI out issues #24944

@Jojo-Schmitz
Copy link
Contributor

then just close this one here

@cbjeukendrup
Copy link
Contributor

Closing as per the comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Midi output sets velocity to 1 for all notes
3 participants