Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4.3] Fix nightly builds on Linux #24826

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

cbjeukendrup
Copy link
Contributor

@cbjeukendrup cbjeukendrup commented Sep 19, 2024

@RomanPudashkin RomanPudashkin merged commit 7411da4 into 4.4.3 Sep 20, 2024
14 checks passed
@RomanPudashkin RomanPudashkin deleted the port/4.4.3/fix_nightly branch September 20, 2024 07:50
@MarcSabatella
Copy link
Contributor

MarcSabatella commented Sep 20, 2024

Thanks for this! But, the naming of the artifacts is different than it was, and is a bit confusing - it's not so clear which are master and which are 4.4.3 builds. For instance, for x86_64, I see these:

image

It looks like the last commit message - or maybe it's the last PR title - is in the name, instead of a branch name. In this case, I can guess the one where the message was "port_4.4.3_fix" is from 4.4.3 branch, but that won't necessarily always be so obvious.

@cbjeukendrup
Copy link
Contributor Author

Oh, those builds should not have been uploaded at all, since I manually ran them with "Publish to FTP: off". How annoying. Anyway, tomorrow there will be normal nightly builds again, but we'll have to delete these bad ones manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants