Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC compiler warnings #24035

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix MSVC compiler warnings #24035

merged 3 commits into from
Aug 20, 2024

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Aug 14, 2024 •
edited
Loading

  • reg.: declaration of 'it' hides previous local declaration (C4456)
  • reg.: conversion from 'size_t' to 'uint/int', possible loss of data (C4267)
  • reg.: not all control paths return a value (C4715)

@Jojo-Schmitz Jojo-Schmitz force-pushed the compiler-warnings branch 2 times, most recently from 7f1dcbe to a198526 Compare August 15, 2024 09:50
@Jojo-Schmitz
Fix MSVC compiler warning
4294cc5 
reg.: declaration of 'it' hides previous local declaration (C4456)
@Jojo-Schmitz
Fix MSVC compiler warnings
84fddb7 
reg.: conversion from 'size_t' to 'int', possible loss of data (C4267)
@Jojo-Schmitz
Fix MSCV compiler warning
f0a584a 
reg.: not all control paths return a value (C4715)
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Aug 20, 2024
Merged
@RomanPudashkin RomanPudashkin merged commit a6e6c7c into musescore:master Aug 20, 2024
11 checks passed
@Jojo-Schmitz Jojo-Schmitz deleted the compiler-warnings branch August 20, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jojo-Schmitz @RomanPudashkin