Work around Opus 1.4+ build failure on armv7l #24017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it failed, sadly |
|
Latest version seems to work. @theofficialgman do you think this is good? |
Yes I think that's good. |
shoogle
approved these changes
Aug 13, 2024
|
Could you merge with the "Squash and merge" option? |
|
Yes, that's the plan, if we're all happy with this solution :) |
cbjeukendrup
added a commit
to cbjeukendrup/MuseScore
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24015
We'll see if it works at https://github.com/cbjeukendrup/MuseScore/actions/runs/10372975091/job/28716972470
I wonder though how this affects performance/functionality/quality. Anyway, it should only affect Opus export on Linux armv7l only, so if it has negative effects, those are limited to this specific area.
@theofficialgman FYI :)