Only layout cross-staff slurs within the updated layout range #23994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Aug 12, 2024
miiizen
approved these changes
Aug 12, 2024
mike-spa
pushed a commit
to mike-spa/MuseScore
that referenced
this pull request
Aug 12, 2024
…tched Only layout cross-staff slurs within the updated layout range
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23889
The double-slur glitches appear when triggering a relayout (for instance, trigger a layout on the last system of the last page and observe the double slurs appear on the preceding systems of that same page). This PR fixes that.
The reported issue with dynamic placement isn't really an issue as far as I can tell, it's just that the hairpin has some nonsensical manual offset applied to it. That offset probably used to be "canceled" by the layout system by forcing it to attach to the dynamic, hence why it wasn't apparent. Now that all of that logic has been rewritten, it's likely that these manual offsets aren't good/relevant anymore. A simple ctrl+R fixes it.
