Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17975: Use gap rests when copy/pasting in secondary voices #23987

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix #17975: Use gap rests when copy/pasting in secondary voices #23987

merged 1 commit into from
Aug 13, 2024

Conversation

mathesoncalum
Copy link
Contributor

Resolves: #17975

cbjeukendrup
cbjeukendrup reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • the comment in line 726 is not actual anymore after this change
  • other readers (read400, 302, etc) contain similar code

@mathesoncalum
Copy link
Contributor Author

Thanks @cbjeukendrup - fixed.

read302 and below actually have unreachable pasteStaff methods, so no changes required there.

@mathesoncalum mathesoncalum mentioned this pull request Aug 13, 2024
Merged
@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#17975 FIXED

@RomanPudashkin RomanPudashkin merged commit 11c16c9 into musescore:master Aug 13, 2024
11 checks passed
@mathesoncalum mathesoncalum deleted the 17975-copypaste_gap_rest branch August 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup approved these changes

Assignees

@zacjansheski zacjansheski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy+paste of bar with invisible (deleted) rest in second voice reintroduces deleted rest
4 participants
@mathesoncalum @zacjansheski @cbjeukendrup @RomanPudashkin