Remove unnecessary track mapping code #23968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was conflicting with the newly reimplemented function Staff::getLinkedTrackInStaff. The logic that these pieces of code were trying to handle is now all handled (as it should) in one single place.
mike-spa
force-pushed
the
removeUnnecessaryTrackMappingCode
branch
from
3eff0b8
to
992fd55
Compare
oktophonie
approved these changes
Aug 12, 2024
miiizen
reviewed
Aug 12, 2024
src/engraving/dom/edit.cpp
Outdated
| @@ -6431,15 +6420,6 @@ void Score::undoAddCR(ChordRest* cr, Measure* measure, const Fraction& tick) | |||
|
|
|||
| Staff* ostaff = cr->staff(); | |||
| track_idx_t strack = ostaff->idx() * VOICES + cr->voice(); | |||
There was a problem hiding this comment.
Would cr->track() work here? Just for clarity & consistency.
There was a problem hiding this comment.
Definitely, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23965
The fix was quite simple. The more worrying thing was that such a basic requirement hadn't been covered by any unit tests, so I've created a new one.