Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text of textlines follow voice assignment colour #23959

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Aug 8, 2024

Resolves: #23937

Text items get their voice assignment property from their parent if their parent is a text line segment.

@oktophonie
Copy link
Contributor

An existing issue (not caused by this PR) but, in case it can be fixed here: when changing the voice assignment using the toolbar buttons or keyboard shortcuts (Ctrl+Alt+0...4), the dotted line changes colour immediately, but the text portion returns to the unselected colour (i.e. black). Using the voice assignment controls in Properties works fine.

box-240808-1938-52.mp4

@mike-spa mike-spa merged commit 3e19bb8 into musescore:master Aug 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crescendo and decrescendo line text should be "All voices" purple color
4 participants