Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fontengine=directwrite for Windows, antialiasing = true, smooth = true #23925

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

igorkorsukov
Copy link
Contributor

@igorkorsukov igorkorsukov commented Aug 6, 2024

Resolves: #23430
Resolves: #24287

@ShibuyaCyana
Copy link

ShibuyaCyana commented Sep 1, 2024

This PR made things look thicker, but also more blurry, just like the effect of disabling ClearType on Windows.
(left = this PR artifact, right = 4.4.0 release, same below)
100

Much more blurriness, if system level scaling is set to 125%:
1252

And text edges become little jagged - distinct in certain (MuseScore) zoom values, likely 200%, 400% or 800%. Here's 400% for example:
400

@ShibuyaCyana
Copy link

ShibuyaCyana commented Sep 1, 2024

As for #15242, here's a 3-way comparison.
MuseScore preview zooming 100%: (mid: this PR build, right: current master)
3COMP100
To me, comparing to v3.6, it looks like this build is using about the same rendering methodology, but without antialiasing. Notice how bad the "g" in "Change Instr." looks.

MuseScore preview zooming 150%, obvious jagged text:
3COMP125

I didn't include system level scaling because in 3.6 Palette and Score panel don't respond to it. Their contents stay at the same pixel size, no matter how big the surrounding elements are:
ss
Which means there won't be any blurriness, but also no HiDPI support.

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Sep 24, 2024

@igorkorsukov Tested on Win10 (2K display) and Win11 (FullHD display).
#23430 looks fixed, #24287 I can't check (unable to reproduce the bug)

About regressions, I have the same the results as @ShibuyaCyana

Comparing with master (and 4.3.2), text inside score and inside palettes became more sharpened on 100,200% and also more blurry on 125,150%

Also, I found that on Win11(FullHD) on 100% text of tabs in Preferences is shorter (with ...) when there is enough space. It's regression comparing with master (and 4.3.2)

bandicam.2024-09-24.15-27-04-429.mp4

@igorkorsukov igorkorsukov changed the title Set fontengine=directwrite for Windows Set fontengine=directwrite for Windows, antialiasing = true, smooth = true Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants