stop playback when opening preferences

to avoid potential problems when changing buffer size, output device, etc.
musescore · Jun 26, 2024 · af65bb5 · af65bb5
1 parent ec1022f
commit af65bb5
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/appshell/internal/applicationactioncontroller.cpp b/src/appshell/internal/applicationactioncontroller.cpp
@@ -288,6 +288,25 @@ void ApplicationActionController::openAskForHelpPage()
 }
 
 void ApplicationActionController::openPreferencesDialog()
+{
+    const context::IPlaybackStatePtr state = globalContext()->playbackState();
+    if (state->playbackStatus() == audio::PlaybackStatus::Running) {
+        dispatcher()->dispatch("stop");
+
+        async::Channel<audio::PlaybackStatus> statusChanged = state->playbackStatusChanged();
+        statusChanged.onReceive(this, [statusChanged, this](audio::PlaybackStatus) {
+            auto statusChangedMut = statusChanged;
+            statusChangedMut.resetOnReceive(this);
+            doOpenPreferencesDialog();
+        });
+
+        return;
+    }
+
+    doOpenPreferencesDialog();
+}
+
+void ApplicationActionController::doOpenPreferencesDialog()
 {
     if (multiInstancesProvider()->isPreferencesAlreadyOpened()) {
         multiInstancesProvider()->activateWindowWithOpenedPreferences();

diff --git a/src/appshell/internal/applicationactioncontroller.h b/src/appshell/internal/applicationactioncontroller.h
@@ -39,6 +39,7 @@
 #include "istartupscenario.h"
 #include "iapplication.h"
 #include "extensions/iextensioninstaller.h"
+#include "context/iglobalcontext.h"
 
 namespace mu::appshell {
 class ApplicationActionController : public QObject, public muse::actions::Actionable, public muse::async::Asyncable
@@ -55,6 +56,7 @@ class ApplicationActionController : public QObject, public muse::actions::Action
     muse::Inject<IStartupScenario> startupScenario;
     muse::Inject<muse::IApplication> application;
     muse::Inject<muse::extensions::IExtensionInstaller> extensionInstaller;
+    muse::Inject<context::IGlobalContext> globalContext;
 
 public:
     void preInit();
@@ -91,6 +93,7 @@ class ApplicationActionController : public QObject, public muse::actions::Action
     void openOnlineHandbookPage();
     void openAskForHelpPage();
     void openPreferencesDialog();
+    void doOpenPreferencesDialog();
 
     void revertToFactorySettings();