Implemented config reset command #401
Conversation
mxpy data parse: remove undesired warning message
multiversx_sdk_cli/cli_config.py
Outdated
| answer = input(f"The file `{str(file)}` will be deleted. Do you want to continue? (y/n)") | ||
| if answer.lower() not in ["y", "yes"]: |
There was a problem hiding this comment.
maybe also strip spaces in answer?
| proxy = ProxyNetworkProvider("https://devnet-api.multiversx.com") | ||
| proxy = ProxyNetworkProvider("https://testnet-api.multiversx.com") |
There was a problem hiding this comment.
so do we change to testnet in tests? or it was just temporarly for testing
There was a problem hiding this comment.
Because of the devnet situation, the tests we're failing, so that's why I switched to testnet. We can switch for now because it seems it'a a little bit more stable.
pyproject.toml
Outdated
| @@ -4,7 +4,7 @@ build-backend = "hatchling.build" | |||
|
|
|||
| [project] | |||
| name = "multiversx-sdk-cli" | |||
| version = "9.3.0" | |||
| version = "9.3.1" | |||
multiversx_sdk_cli/cli_config.py
Outdated
| logger.info("Successfully deleted the config file") | ||
|
|
||
|
|
||
| def confirm_continuation(file: Path): |
There was a problem hiding this comment.
The function can be renamed to contain the specific action (e.g. deletion of the file), or it can be changed to receive the message as a parameter - and then it will be a more generic function (e.g. maybe for ux.py).
There was a problem hiding this comment.
moved the function in ux.py and made it more generic.
| "--value", "1250000000000000000000", | ||
| "--total-delegation-cap", "10000000000000000000000", | ||
| "--service-fee", "100", | ||
| "--proxy", "https://testnet-api.multiversx.com" | ||
| "--chain", "T" |
There was a problem hiding this comment.
Proxy not needed here?
There was a problem hiding this comment.
No, because we are not sending the transaction. We used the proxy just to get the nonce which in our test it's not really relevant.
Implemented a new command
mxpy config resetthat can be used to delete themxpy.jsonconfig file.