Replace transaction class with the one from sdk-core

[popenta]

In this PR the class BunchOfTransactions has also been removed, as it was not used within mxpy.
As some people were referencing mxpy as a package just to use this class, the following code is an alternative implementation to that class, that can be copied into your own project and used directly.

from typing import Any, Dict, List, Optional, Protocol, Tuple

from multiversx_sdk_core import Transaction, TransactionPayload
from multiversx_sdk_wallet import UserSigner


class IAddress(Protocol):
    def bech32(self) -> str:
        ...


class ITransaction(Protocol):
    def to_dictionary(self) -> Dict[str, Any]:
        ...


class INetworkProvider(Protocol):
    def send_transactions(self, transactions: List[ITransaction]) -> Tuple[int, str]:
        ...


class BunchOfTransactions:
    def __init__(self) -> None:
        self.transactions: List[Transaction] = []

    def add_prepared(self, transaction: Transaction) -> None:
        self.transactions.append(transaction)

    def add(self,
            sender: UserSigner,
            receiver_address: IAddress,
            chain: str,
            gas_limit: int,
            nonce: int,
            value: int,
            data: str,
            gas_price: Optional[int] = None,
            version: Optional[int] = None,
            options: Optional[int] = None) -> None:
        tx = Transaction(
            chain_id=chain,
            sender=sender.get_pubkey().to_address("erd"),
            receiver=receiver_address,
            gas_limit=gas_limit,
            gas_price=gas_price,
            nonce=nonce,
            value=value,
            data=TransactionPayload.from_str(data),
            version=version,
            options=options
        )

        tx.signature = sender.sign(tx)
        self.transactions.append(tx)

    def send(self, proxy: INetworkProvider) -> Tuple[int, str]:
        logger.info(f"BunchOfTransactions.send: {len(self.transactions)} transactions")
        num_sent, hashes = proxy.send_transactions(self.transactions)
        return num_sent, hashes

[andreibancioiu]

Good, we reference the release from feat/*, for now.

[andreibancioiu]

I think SmartContract is the next in line, to be removed (replaced).

[popenta]

I agree. I don't know if we should do it now or wait for the sdk to be compliant with the specs.

[andreibancioiu]

I think these tests can be removed (the one with signing a transaction), since we have them (most of the flow, at least) in sdk-core, as well. Can stay for now, but we can remove them in the future.

[popenta]

Yes, indeed. Will be removed in the future.

[andreibancioiu]

Perhaps we could have used Transaction.from_dictionary?

https://github.com/multiversx/mx-sdk-py-core/blob/main/multiversx_sdk_core/transaction.py#L105

Then, we can remove JSONTransaction as well, I think.

(for a future PR).

[popenta]

Indeed. I forgot we have that in sdk-core. Will be replaced in a future PR.