Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross header notarization fix #6461

Open
wants to merge 2 commits into
base: feat/chain-go-sdk
Choose a base branch
from

Conversation

axenteoctavian
Copy link

@axenteoctavian axenteoctavian commented Sep 13, 2024

Reasoning behind the pull request

  • The same first dummy cross header is added in the block tracker until a valid cross chain header was received

Proposed changes

  • Only if there's a new cross chain header processed then call the save function

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant