Degree filter on large query #416
Conversation
✅ Deploy Preview for multimatrix ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Netlify does not like how I am treating the hover object -- I tried to add a check for it but it didn't work. Line 167, MultiMatrix.vue |
|
Test Query: RPC1, |
| @@ -389,6 +390,10 @@ const { | |||
| state.nodeDegreeDict = degreeObject.nodeDegreeDict; | |||
| }, | |||
|
|
|||
| setMinDegree(state, minDegree: number) { | |||
There was a problem hiding this comment.
We don't have a setMaxDegree, why can't we just get this info from setDegreeNetwork or another setDegreeEntries?
There was a problem hiding this comment.
I want to keep it separate because in ControlPanel.vue minDegree is a computed value and it should be 0 unless it is a large query
There was a problem hiding this comment.
We met to discuss this. There are likely some edge cases that this will break
|
Created issue #417 because although this solves larger query results, it is not a solution for very large query returns that crash the browser. Example query: |
Does this PR close any open issues?
Closes #415
Give a longer description of what this PR addresses and why it's needed
At the moment we don't have any way to display results from queries that are > 100.
Adding a check to see how large the query result is will trigger a filtered matrix.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: