[docs] Fix Google Analytics going to the wrong property #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
|
These are the results for the performance tests:
|
cherniavskii
approved these changes
Nov 3, 2022
| eslint: { | ||
| ignoreDuringBuilds: true, | ||
| }, | ||
| module.exports = withDocsInfra({ |
There was a problem hiding this comment.
Just to confirm I understand it correctly - was the issue here that without withDocsInfra the DEPLOY_ENV variable was missing and development GOOGLE_ANALYTICS_ID was used by default?
There was a problem hiding this comment.
@cherniavskii Yes, correct.
I feel that at this point, it's not worth adding more checks as we don't market our docs infra as a standalone open-source project and all the other docs are using withDocsInfra now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on this slide: https://docs.google.com/presentation/d/1wnNqlD5KBIOACRb-mutSiU8fLTqjBlff-2y8j4kDMMc/edit#slide=id.g1626cc333d1_0_16, I saw something very strange on Google Analytics:
https://analytics.google.com/analytics/web/#/report-home/a106598593w159022482p272132536
The hits are sent to the development property instead of the production one.
It turns out that we updated the mono repository #6570 to a version that requires
withDocsInfra()to set the env variables requires by the docs. I have copieddocs/next.config.jsthat we have on the next branch and applied it to the master branch. I didn't think about this when I introduced thewithDocsInfra()abstraction. I should probably have added some logic so it fails upfront with the env values missing, too late.