Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSV export format options #1309

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Add CSV export format options #1309

merged 2 commits into from
Apr 11, 2024

Conversation

flowrean
Copy link
Contributor

This PR adds options from csv-stringify to the extension settings, allowing users to customize the format of the generated CSV when exporting. The new settings are all in the group sqltools.csvExport, which allows to directly pass all values at once to csv-stringify. The default settings reflect the current option values.

The changes made here partly close #739. I was planning to add an option to change the CSV field separator and ended up adding some additional related options that might be useful to tweak the resulting CSV. In #739, the decimal separator is also mentioned. I don't handle this here, as it does not seem specifically related to the CSV format (could also apply to the JSON export).


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have left some review comments based on code-reading (haven't done any testing).

packages/extension/package.json Outdated Show resolved Hide resolved
packages/types/index.d.ts Outdated Show resolved Hide resolved
@flowrean
Copy link
Contributor Author

Those are valid comments. I made the changes.

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gjsjohnmurray gjsjohnmurray merged commit 2a42731 into mtxr:dev Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add localization options for CSV export
2 participants