MySql Driver Configuration Bug Fix (EnableSsl) #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set SSL as disabled and delete empty object if no SSL details supplied
Fludem
changed the title
gjsjohnmurray
approved these changes
Apr 12, 2024
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode-sqltools
that referenced
this pull request
Apr 12, 2024
Also set SSL as disabled and delete empty object if no SSL details supplied
gjsjohnmurray
added a commit
to gjsjohnmurray/vscode-sqltools
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If enableSSL is ticked but object is left empty we now disable enableSSL
If enableSsl is false, we delete the object.
I'm not sure if their is use case for having enableSsl as true but not specifying parameters. Sorry!
Fixes #1270