Don't reject whole batch of files because some of them failed to load… #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. Fixes "Parse All Files" (issue #54).
As I mentioned in #54, when
FileReader.readFileFromNames()failes to read any single file within a batch, it would reject it's Promise, spawning an error which led to valid files being discarded andOutputWriterhaving inconsistent state. This commit fixes that.This does not fix the
OutputWriterstate management issues directly. They should still be dealt with in another patch.While "Parse All Files" now works correctly, there is an issue with VS code that will make it spawn "Uncaught exception" errors whenever
workspace.openTextDocument()fails to open a file. See microsoft/vscode#27809 and microsoft/vscode#28069 for details.