Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont work - Parse TODOs (all files) #54

Open
IgorNovozhilov opened this issue Mar 13, 2017 · 1 comment
Open

Dont work - Parse TODOs (all files) #54

IgorNovozhilov opened this issue Mar 13, 2017 · 1 comment

Comments

@IgorNovozhilov
Copy link
Contributor

vers:
TODO Parser - 1.8.7
VSCode - 1.11.0-insider

Steps:

  1. Press F1 > Parse TODOs (all files)
  2. Click to "TODO Counter"
  3. No reaction
  4. Open console:
shell.ts:468 Previous work is not finished.: AssertionError: Previous work is not finished.
    at Function.OutputWriter.begin (C:\Users\xxx\.vscode-insiders\extensions\minhthai.vscode-todo-parser-1.8.7\out\src\classes\OutputWriter.js:22:9)
    at C:\Users\xxx\.vscode-insiders\extensions\minhthai.vscode-todo-parser-1.8.7\out\src\types\CommandType.js:15:36
    at process._tickCallback (internal/process/next_tick.js:103:7)
@peacegiverman
Copy link

I think this happens when there are binary files in the workspace. When FileReader.readFileLoop() tries to open a binary file, it returns this error Detail: File seems to be binary and cannot be opened as text to the read callback and spoils the whole batch, even if there are valid files in it. This can then result in no todos being parsed and nothing being written to the OutputWriter, thus leaving it in an Idle state, instead of Busy which is expected.

peacegiverman pushed a commit to peacegiverman/vscode-todo-parser that referenced this issue Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants