Move CI to github actions #433
Conversation
r-ash
force-pushed
the
gh-actions
branch
2 times, most recently
from
544b006
to
42d21ab
Compare
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Login to Docker Hub |
There was a problem hiding this comment.
Do we want to avoid going via docker hub soon and only go via ghcr? You'll need to arrange a new dockerhub account otherwise, and they will definitely consider Avenir commercial
There was a problem hiding this comment.
Yes, expecting we can remove this soon. I'll get deployment working off ghcr and then can remove this
DESCRIPTION
Outdated
| mrc-ide/mockr, | ||
| mrc-ide/testthat.buildkite, | ||
| duckdb/[email protected] | ||
| mrc-ide/naomi.options |
There was a problem hiding this comment.
It is, removed that line.
NAMESPACE
Outdated
| @@ -1,5 +1,6 @@ | |||
| # Generated by roxygen2: do not edit by hand | |||
|
|
|||
| S3method(naomi::print,naomi_areas) | |||
There was a problem hiding this comment.
This is odd for two reasons:
- does
printnot work as the generic? - should naomi not implement this?
There was a problem hiding this comment.
Thanks, think this was me not understanding when you should use @exportS3method over @export. Have updated this to @export now which I think is correct (from https://roxygen2.r-lib.org/articles/namespace.html#s3) I've fixed the signature too to actually match print.
R/areas.R
Outdated
| @@ -160,6 +160,7 @@ create_areas <- function(levels = NULL, hierarchy = NULL, boundaries = NULL, | |||
| v | |||
| } | |||
|
|
|||
| #' @exportS3Method naomi::print | |||
| @@ -1,6 +1,6 @@ | |||
| ## Naomi <img src='images/naomi_hex.png' align="right" height="139" /> | |||
|
|
|||
| [](https://travis-ci.org/mrc-ide/naomi) | |||
docker/teamcity
Outdated
Co-authored-by: Rich FitzJohn <[email protected]>
In moving this to Avenir we'll no longer have access to the buildkite runners. We can use github actions free runners to achieve what we need instead.
This PR will