Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False convergence warning to error #402

Merged
merged 11 commits into from
Mar 26, 2024
Merged

False convergence warning to error #402

merged 11 commits into from
Mar 26, 2024

Conversation

rtesra
Copy link
Collaborator

@rtesra rtesra commented Mar 28, 2023

No description provided.

@rtesra rtesra requested a review from r-ash March 28, 2023 15:22
@vimc-robot vimc-robot mentioned this pull request Mar 28, 2023
Closed
@vimc-robot
Copy link

Thanks. Corresponding hintr PR at hivtools/hintr#462

@rtesra rtesra mentioned this pull request Mar 29, 2023
Closed
@r-ash r-ash removed their request for review May 3, 2023 10:16
@r-ash r-ash marked this pull request as draft May 3, 2023 10:16
@rtesra rtesra marked this pull request as ready for review March 13, 2024 12:38
@r-ash r-ash requested review from r-ash and jeffeaton March 25, 2024 16:26
r-ash
r-ash approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@r-ash r-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, can you bump the version number?

@r-ash r-ash merged commit 6a8e9c6 into master Mar 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-ash r-ash r-ash approved these changes

@jeffeaton jeffeaton Awaiting requested review from jeffeaton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtesra @vimc-robot @r-ash