Change -n to ! -z for token check

mproffitt · Apr 25, 2024 · c9a3db6 · c9a3db6
1 parent 8f51e7b
commit c9a3db6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/localstack-kind.sh b/localstack-kind.sh
@@ -14,7 +14,7 @@ DEFAULT_PROVIDERS=(
   "function-go-templating"
 )
 
-if [ -n $LOCALSTACK_AUTH_TOKEN ]; then
+if [ ! -z $LOCALSTACK_AUTH_TOKEN ]; then
   DEFAULT_PROVIDERS+=(
     "rds"
     "eks"
@@ -265,7 +265,7 @@ header "Installing localstack..."
   yq -ie 'del(.extraEnvVars[] | select(.name == "LOCALSTACK_AUTH_TOKEN"))' localstack-values.yaml
   yq -ie '.image.repository = "localstack/localstack"' localstack-values.yaml
 
-  if [ -n "$LOCALSTACK_AUTH_TOKEN" ]; then
+  if [ ! -z "$LOCALSTACK_AUTH_TOKEN" ]; then
     echo "  [localstack] Installing localstack-pro..."
     echo "  [localstack] Creating localstack-auth-token secret..."
     kubectl create secret generic localstack-auth-token --namespace localstack-system \

diff --git a/localstack-values.yaml b/localstack-values.yaml
@@ -11,11 +11,6 @@ extraEnvVars:
       secretKeyRef:
         name: localstack-auth-token
         key: token
-  - name: LOCALSTACK_AUTH_TOKEN
-    valueFrom:
-      secretKeyRef:
-        name: localstack-auth-token
-        key: token
 debug: true
 mountDind:
   enabled: true