Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to wasm-bindgen #474

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

ochameau
Copy link
Contributor

While looking at #473 I realized that we may benefit from migrating to wasm-bindgen instead of bundling rust's wasm very manually. Hopefully this may handle some type convertion for us. But it would also ease logging from the Rust code and use the typical toolchain to integrate Rust into nodejs/browser apps.

Unfortunately, this isn't actionnable just yet. This is blocked on supporting ES Modules in Workers in Firefox.
wasm-bindgen only support generating ES Modules for browser target.
Using nodejs target introduce the usage of various node-only modules (path and fs).
The no-modules target isn't easily usage in Firefox codebase from our CommonJS loader. (Nor from nodejs)

Hopefully we start support workers soon in Firefox as this patch would also allow loading the WASM synchronously in nodejs.
This would ultimately help get rid of async APIs in the library! And we would also be able to migrate to ES Modules in all modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant