Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(browser): swap URL polyfill #413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukeed
Copy link

@lukeed lukeed commented Dec 17, 2019

Hey there,

I put together a 1.5kB polyfill specifically to unblock this issue: #400

We'd really like to move forward with source-map integration within the Svelte REPL environment, but not at the expense of nearly doubling its javascript! With whatwg-url included – which is rarely needed (especially on a developer machine) – source-map weighs 30% more than CodeMirror.

This polyfill, like whatwg-url, polyfills the URL implementation from Node.js instead of the browser's. It also passes the linked Chromium & Mozilla issues.

@coveralls
Copy link

coveralls commented Dec 17, 2019

Pull Request Test Coverage Report for Build 578

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.713%

Totals Coverage Status
Change from base Build 576: 0.0%
Covered Lines: 2481
Relevant Lines: 2733

💛 - Coveralls

@lukeed
Copy link
Author

lukeed commented Dec 20, 2019

Hey :) I know we're all busy with the holidays, but just wanted to check in. If this has no chance of landing, that's totally fine, but please let me know so that our side can start formulating backup plans in order to move forward.

Thanks! ☃️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants