ci: Run clippy on all platforms
#2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we get issues for platform-specific code. Also change `macos-14` -> `macos-latest` everywhere.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
=======================================
Coverage ? 95.35%
=======================================
Files ? 112
Lines ? 36335
Branches ? 0
=======================================
Hits ? 34648
Misses ? 1687
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to d6279bf. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [134.95 ns 135.99 ns 137.65 ns]
change: [+35.233% +35.998% +36.851%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [165.25 ns 165.79 ns 166.33 ns]
change: [+40.141% +40.797% +41.397%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [164.69 ns 165.26 ns 165.90 ns]
change: [+39.722% +40.576% +41.307%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: 💔 Performance has regressed. time: [138.28 ns 138.45 ns 138.63 ns]
change: [+40.759% +41.880% +42.795%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.79 ms 111.84 ms 111.90 ms]
change: [+0.5702% +0.6418% +0.7122%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.458 ms 27.705 ms 28.939 ms]
change: [-7.3012% -1.5130% +4.9817%] (p = 0.64 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [36.467 ms 38.134 ms 39.796 ms]
change: [-2.7432% +3.9825% +11.695%] (p = 0.27 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [26.027 ms 26.824 ms 27.622 ms]
change: [-2.4103% +2.0917% +6.5536%] (p = 0.35 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [41.834 ms 44.522 ms 47.228 ms]
change: [-3.9072% +3.2513% +11.562%] (p = 0.41 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [112.65 ms 113.13 ms 113.59 ms]
thrpt: [880.40 MiB/s 883.97 MiB/s 887.74 MiB/s]
change:
time: [-1.6310% -1.1234% -0.6488%] (p = 0.00 < 0.05)
thrpt: [+0.6530% +1.1362% +1.6580%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [310.93 ms 314.62 ms 318.26 ms]
thrpt: [31.420 Kelem/s 31.784 Kelem/s 32.161 Kelem/s]
change:
time: [-2.9109% -1.3456% +0.2944%] (p = 0.10 > 0.05)
thrpt: [-0.2935% +1.3640% +2.9982%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold. time: [33.735 ms 33.932 ms 34.141 ms]
thrpt: [29.291 elem/s 29.471 elem/s 29.643 elem/s]
change:
time: [-1.9031% -1.0755% -0.2413%] (p = 0.01 < 0.05)
thrpt: [+0.2419% +1.0872% +1.9400%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we get issues for platform-specific code.
Also change
macos-14->macos-latesteverywhere.