ci: Empty all QNS logs >5MB before artifact upload #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because these artifacts are huge and those logs are not useful for debugging.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
larseggert
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2071 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 112 112
Lines 36505 36505
=======================================
Hits 34811 34811
Misses 1694 1694 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to adf4722. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.426 ns 99.810 ns 100.22 ns]
change: [+0.4686% +0.9220% +1.4267%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [118.11 ns 118.39 ns 118.70 ns]
change: [+0.1623% +0.8792% +1.9203%] (p = 0.03 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [118.01 ns 118.56 ns 119.18 ns]
change: [+0.1890% +0.7632% +1.3144%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.061 ns 103.22 ns 114.47 ns]
change: [+0.0832% +3.0167% +7.4749%] (p = 0.16 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.28 ms 111.41 ms 111.63 ms]
change: [-0.4412% -0.1905% +0.0526%] (p = 0.12 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.976 ms 28.086 ms 29.194 ms]
change: [-4.6893% +0.3117% +6.0980%] (p = 0.91 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.534 ms 36.001 ms 37.490 ms]
change: [-6.9616% -0.5777% +6.2341%] (p = 0.86 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.319 ms 32.158 ms 32.971 ms]
change: [-4.6868% -1.3193% +2.0166%] (p = 0.45 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [42.619 ms 45.608 ms 48.601 ms]
change: [-14.808% -7.0115% +0.8266%] (p = 0.10 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [115.23 ms 115.67 ms 116.10 ms]
thrpt: [861.30 MiB/s 864.50 MiB/s 867.79 MiB/s]
change:
time: [+0.0860% +0.9279% +1.6036%] (p = 0.01 < 0.05)
thrpt: [-1.5783% -0.9194% -0.0859%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [312.33 ms 316.24 ms 320.22 ms]
thrpt: [31.229 Kelem/s 31.622 Kelem/s 32.017 Kelem/s]
change:
time: [-1.4749% +0.1940% +2.0156%] (p = 0.83 > 0.05)
thrpt: [-1.9757% -0.1937% +1.4970%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [40.238 ms 40.940 ms 41.643 ms]
thrpt: [24.014 elem/s 24.426 elem/s 24.852 elem/s]
change:
time: [-1.7507% +0.6434% +3.0344%] (p = 0.61 > 0.05)
thrpt: [-2.9451% -0.6393% +1.7819%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Aug 22, 2024
larseggert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because these artifacts are huge and those logs are not useful for debugging.