refactor: drop time crate in favor of std::time::SystemTime #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
commented
Aug 19, 2024
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2059 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 112 112
Lines 36499 36505 +6
=======================================
+ Hits 34804 34811 +7
+ Misses 1695 1694 -1 ☔ View full report in Codecov by Sentry. |
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Benchmark resultsPerformance differences relative to e3d8be4. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.578 ns 99.938 ns 100.31 ns]
change: [-0.3532% +0.0371% +0.4631%] (p = 0.86 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.62 ns 117.93 ns 118.26 ns]
change: [-0.9587% -0.4465% -0.0127%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.04 ns 117.49 ns 118.04 ns]
change: [-1.9023% -0.8571% -0.0179%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.682 ns 97.828 ns 97.989 ns]
change: [-0.7288% +0.3282% +1.4279%] (p = 0.55 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.24 ms 111.30 ms 111.36 ms]
change: [-0.0123% +0.0497% +0.1168%] (p = 0.13 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.686 ms 27.540 ms 28.425 ms]
change: [-3.9239% +0.8442% +5.9065%] (p = 0.74 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.695 ms 37.252 ms 38.865 ms]
change: [-4.3242% +2.1626% +9.3183%] (p = 0.53 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [30.848 ms 31.704 ms 32.555 ms]
change: [-4.0294% -0.5016% +3.3226%] (p = 0.78 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [42.910 ms 45.644 ms 48.406 ms]
change: [-12.054% -4.4350% +4.0698%] (p = 0.29 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.94 ms 114.49 ms 114.99 ms]
thrpt: [869.65 MiB/s 873.48 MiB/s 877.65 MiB/s]
change:
time: [-1.0327% -0.2890% +0.3870%] (p = 0.45 > 0.05)
thrpt: [-0.3855% +0.2899% +1.0435%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold. time: [308.66 ms 312.20 ms 315.82 ms]
thrpt: [31.663 Kelem/s 32.031 Kelem/s 32.398 Kelem/s]
change:
time: [+0.6662% +2.3693% +4.0217%] (p = 0.01 < 0.05)
thrpt: [-3.8662% -2.3144% -0.6618%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [40.188 ms 40.880 ms 41.565 ms]
thrpt: [24.059 elem/s 24.462 elem/s 24.883 elem/s]
change:
time: [-2.1732% +0.1538% +2.4753%] (p = 0.90 > 0.05)
thrpt: [-2.4155% -0.1535% +2.2214%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
martinthomson
approved these changes
Aug 20, 2024
larseggert
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2053.