Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Prep env for custom NSS build #2046

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 9, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

github-actions bot commented Aug 9, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

test/test.sh Outdated Show resolved Hide resolved
test/test.sh Show resolved Hide resolved
Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (9c54b4a) to head (919beb0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
+ Coverage   95.33%   95.36%   +0.03%     
==========================================
  Files         112      112              
  Lines       36475    36475              
==========================================
+ Hits        34772    34783      +11     
+ Misses       1703     1692      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert added this pull request to the merge queue Aug 9, 2024
Merged via the queue into mozilla:main with commit f801c29 Aug 9, 2024
54 of 56 checks passed
@larseggert larseggert deleted the test-nss-libs branch August 9, 2024 14:10
Copy link

github-actions bot commented Aug 9, 2024

Benchmark results

Performance differences relative to ca0080e.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [192.85 ns 193.30 ns 193.77 ns]
       change: [-1.6355% -0.8691% -0.2397%] (p = 0.01 < 0.05)

Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [235.82 ns 236.48 ns 237.19 ns]
       change: [-0.3006% +0.0250% +0.3931%] (p = 0.88 > 0.05)

Found 21 outliers among 100 measurements (21.00%)
1 (1.00%) low severe
1 (1.00%) low mild
5 (5.00%) high mild
14 (14.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [236.16 ns 236.75 ns 237.52 ns]
       change: [-0.1139% +0.3446% +0.8615%] (p = 0.16 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [216.81 ns 217.08 ns 217.38 ns]
       change: [-0.6994% -0.0219% +0.7141%] (p = 0.96 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) high mild
8 (8.00%) high severe

RxStreamOrderer::inbound_frame(): 💚 Performance has improved.
       time:   [118.70 ms 118.78 ms 118.87 ms]
       change: [-2.2577% -2.1832% -2.1035%] (p = 0.00 < 0.05)

Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [39.382 ms 41.138 ms 42.918 ms]
       change: [-8.1527% -1.7307% +4.8804%] (p = 0.61 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [55.457 ms 58.583 ms 61.768 ms]
       change: [-7.2682% +0.0173% +7.5104%] (p = 1.00 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [48.119 ms 49.575 ms 51.011 ms]
       change: [-4.9084% -0.8661% +3.6259%] (p = 0.70 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [63.537 ms 70.808 ms 78.077 ms]
       change: [-17.455% -4.6453% +7.6617%] (p = 0.49 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [169.17 ms 170.72 ms 172.32 ms]
       thrpt:  [580.33 MiB/s 585.74 MiB/s 591.12 MiB/s]
change:
       time:   [-3.1902% -1.4937% +0.1883%] (p = 0.09 > 0.05)
       thrpt:  [-0.1880% +1.5163% +3.2953%]

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [405.25 ms 408.49 ms 411.67 ms]
       thrpt:  [24.291 Kelem/s 24.481 Kelem/s 24.676 Kelem/s]
change:
       time:   [-1.0815% +0.0523% +1.1552%] (p = 0.92 > 0.05)
       thrpt:  [-1.1420% -0.0523% +1.0933%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [46.121 ms 46.863 ms 47.615 ms]
       thrpt:  [21.002  elem/s 21.339  elem/s 21.682  elem/s]
change:
       time:   [-2.4983% -0.3264% +1.8880%] (p = 0.78 > 0.05)
       thrpt:  [-1.8530% +0.3275% +2.5623%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 209.9 ± 106.2 109.1 426.3 1.00
neqo msquic reno on 291.6 ± 54.9 263.4 445.4 1.00
neqo msquic reno 316.7 ± 87.8 261.5 492.7 1.00
neqo msquic cubic on 311.0 ± 82.2 255.5 473.1 1.00
neqo msquic cubic 302.6 ± 72.7 249.4 468.9 1.00
msquic neqo reno on 166.4 ± 76.7 111.7 402.0 1.00
msquic neqo reno 199.6 ± 80.2 118.1 399.8 1.00
msquic neqo cubic on 201.2 ± 56.8 117.6 352.4 1.00
msquic neqo cubic 247.1 ± 110.4 116.9 428.1 1.00
neqo neqo reno on 212.3 ± 88.8 146.5 395.0 1.00
neqo neqo reno 218.1 ± 84.0 156.9 395.3 1.00
neqo neqo cubic on 194.2 ± 49.5 162.6 346.1 1.00
neqo neqo cubic 235.4 ± 99.3 163.0 473.6 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants