Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): remove needless process_output in process_input #1922

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
+2 −3
Draft

fix(client): remove needless process_output in process_input #1922

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d533d6e
fix(neqo-client): remove unnecessary process_output call in process_m…
mxinden Jun 13, 2024
e5ef460
Merge branch 'main' of https://github.com/mozilla/neqo into rmv-out-i…
mxinden Jun 18, 2024
636e5df
Merge branch 'main' into rmv-out-in-in
larseggert Jun 18, 2024
1907d44
Merge branch 'main' into rmv-out-in-in
larseggert Jun 18, 2024
8455093
Trigger CI
mxinden Jun 26, 2024
a1e9b86
Merge branch 'main' into rmv-out-in-in
larseggert Jul 2, 2024
0d8ff09
Trigger benchmarks
mxinden Jul 2, 2024
619d8c9
Merge branch 'main' of https://github.com/mozilla/neqo into rmv-out-i…
mxinden Jul 25, 2024
6310058
Merge branch 'main' into rmv-out-in-in
mxinden Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions neqo-bin/src/client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ impl<'a, H: Handler> Runner<'a, H> {
}

match ready(self.socket, self.timeout.as_mut()).await? {
Ready::Socket => self.process_multiple_input().await?,
Ready::Socket => self.process_multiple_input()?,
Ready::Timeout => {
self.timeout = None;
}
Expand Down Expand Up @@ -441,15 +441,14 @@ impl<'a, H: Handler> Runner<'a, H> {
Ok(())
}

async fn process_multiple_input(&mut self) -> Res<()> {
fn process_multiple_input(&mut self) -> Res<()> {
loop {
let dgrams = self.socket.recv(&self.local_addr)?;
if dgrams.is_empty() {
break;
}
self.client
.process_multiple_input(dgrams.iter(), Instant::now());
self.process_output().await?;
}

Ok(())
Expand Down
Loading