Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3646 - Align Sign in button with Monitor logo #5122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Oct 1, 2024

References:

Jira: MNTOR-3646
Figma:

Description

Screenshot (if applicable)

Screen.Recording.2024-10-01.at.10.30.42.AM.mov

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist requested review from Vinnl and flozia October 1, 2024 14:36
</a>
</mj-text>
</mj-column>
<mj-group>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mj-group forces both mj-column on the same row, similar to a flexbox. As such, the 70% and 30% widths apply on smaller device widths. I added a video demo.

Copy link

github-actions bot commented Oct 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant