Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .github folder from dockerignore so docker build can find upstream.repos #877

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

mishra39
Copy link
Contributor

Description

Please explain the changes you made, including a reference to the related issue if applicable
This PR aims to fix the docker build.
Currently, the command RUN vcs import src < src/moveit2_tutorials/.github/upstream.repos provided in Dockerfile fails as the .github folder is not copied over when COPY . src/moveit2_tutorials is run.
To fix this issue, **/.github needs to be removed from the .dockerignore file.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@sjahr sjahr requested a review from henningkayser June 20, 2024 08:55
@rhaschke rhaschke merged commit e03890b into moveit:main Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants