Remove unused panda files #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjahr
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Thanks for this cleanup! Is the CI failure caused by a missing parameter?
Error: ROR] [rviz2-1]: process has died [pid 5763, exit code -6, cmd '/opt/ros/rolling/lib/rviz2/rviz2 -d /home/runner/work/moveit2_tutorials/moveit2_tutorials/.work/target_ws/install/moveit2_tutorials/share/moveit2_tutorials/launch/kinova_moveit_config_demo.rviz --ros-args -r __node:=rviz2 --params-file /tmp/launch_params_kdx_0cq8 --params-file /tmp/launch_params_f782b7sk --params-file /tmp/launch_params_7nnczulk --params-file /tmp/launch_params_xety_h7q --params-file /tmp/launch_params_om7m0nov'].
|
This pull request is in conflict. Could you fix it @abake48? |
abake48
force-pushed
the
pr-remove-panda-examples
branch
from
7ac340a
to
1b3cdf1
Compare
sjahr
approved these changes
Aug 17, 2023
tylerjw
force-pushed
the
pr-remove-panda-examples
branch
from
fef513c
to
ff61e5d
Compare
tylerjw
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the unused panda files, also provides a fix for CI failures as a result of cache misses
Checklist