Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix place pose generation IK frame in MTC Tutorial #727

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Jul 31, 2023

Per the discussion in #723, this PR fixes the IK frame in the MTC tutorial's place pose generation so that the object is not incorrectly rotated by sampling placements in the end effector frame rather than the object frame.

Closes #723

@sea-bass sea-bass added the backport-humble This label signals Mergify to backport this PR to Humble label Jul 31, 2023
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume you successfully tested this 😉

@sea-bass sea-bass self-assigned this Aug 1, 2023
@tylerjw tylerjw self-assigned this Aug 1, 2023
@tylerjw tylerjw merged commit 35048cb into main Aug 8, 2023
8 of 9 checks passed
@tylerjw tylerjw deleted the fix-mtc-place-ik-frame branch August 8, 2023 14:20
mergify bot pushed a commit that referenced this pull request Aug 8, 2023
(cherry picked from commit 35048cb)

# Conflicts:
#	doc/tutorials/pick_and_place_with_moveit_task_constructor/pick_and_place_with_moveit_task_constructor.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label signals Mergify to backport this PR to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Place Poses Generated in MTC Tutorial
3 participants