兼容新版本接口(inuse_objects和inuse_space的上报处理) #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, fibbery, 感谢你的PR，我看了下pyscope最近的release，已经从v0.37.2升级到 v1.0.0了，我们能否测试下这次的改动是否适配1.0呢？ 我理解pyscope 1.0之后有broken change可能性不大。 |
Jun10ng
reviewed
Sep 19, 2023
测试过了，同一个测试用例跑的，这两个版本没看到有兼容行问题。 ps: 感觉response.code的状态码处理方式有点问题，经常看不出来报错是什么 |
Jun10ng
approved these changes
Sep 21, 2023
|
Hi @doujiang24, do u think we need release a new tag for this change? It compatibles Pyscope v1.0. |
|
@Jun10ng Yep, I do think it deserves it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用pyroscope v0.37.2测试发现，heap信息上报之后，在pyroscope找不到inuse_space和inuse_objects，发现pyroscope api有所更新，所以兼容处理一下