[MOSIP-15265] updated db-common-secrets to db-secrets #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in copy_secrets.sh and delete.sh file of config-server.
lalithkota
reviewed
Oct 12, 2022
| @@ -12,7 +12,7 @@ while true; do | |||
| if [ $yn = "Y" ] | |||
| then | |||
| kubectl -n $NS delete configmap global keycloak-host activemq-activemq-artemis-share s3 email-gateway | |||
| kubectl -n $NS delete secret db-common-secrets keycloak keycloak-client-secrets activemq-activemq-artemis softhsm-kernel softhsm-ida s3 email-gateway prereg-captcha | |||
| kubectl -n $NS delete secret db-mosip-audit-secret db-mosip-authdevice-secret db-mosip-credential-secret db-mosip-digitalcard-secret db-mosip-hotlist-secret db-mosip-ida-secret db-mosip-idmap-secret db-mosip-idp-secret db-mosip-idrepo-secret db-mosip-kernel-secret db-mosip-keymgr-secret db-mosip-master-secret db-mosip-pms-secret db-mosip-prereg-secret db-mosip-regdevice-secret db-mosip-regprc-secret db-mosip-resident-secret db-mosip-toolkit-secret keycloak keycloak-client-secrets activemq-activemq-artemis softhsm-kernel softhsm-ida s3 email-gateway prereg-captcha | |||
There was a problem hiding this comment.
Can a regex search be used here like the one used in copy_secrets.sh file? This will be hard to maintain later on when more secrets are added
There was a problem hiding this comment.
yes we can do that changes and add that in delete.sh script.
…evelop-MOSIP-15265 � Conflicts: � deployment/v3/mosip/config-server/delete.sh
…evelop-MOSIP-15265
…evelop-MOSIP-15265
…evelop-MOSIP-15265
syedsalman3753
suggested changes
Oct 21, 2022
There was a problem hiding this comment.
@pramod444 please update postgres README.md file for db_password_gen
|
sure @syedsalman3753 will update. |
…evelop-MOSIP-15265
…evelop-MOSIP-15265
…evelop-MOSIP-15265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in copy_secrets.sh and delete.sh file of config-server.