HashValidator err handling

mosip · Jul 10, 2023 · 921d133 · 921d133
1 parent 71bffed
commit 921d133
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...ompliance-toolkit/src/main/java/io/mosip/compliance/toolkit/validators/HashValidator.java b/...ompliance-toolkit/src/main/java/io/mosip/compliance/toolkit/validators/HashValidator.java
@@ -38,7 +38,6 @@ public ValidationResultDto validateResponse(ValidationInputDto inputDto) {
 
 			String errHashReceived = null;
 			String errGeneratedHashValue = null;
-			String errPreviousHashValue = null;
 			if (!arrBiometricNodes.isNull() && arrBiometricNodes.isArray()) {
 				for (final JsonNode biometricNode : arrBiometricNodes) {
 					log.info("previousHash {}", previousHash);
@@ -66,9 +65,11 @@ public ValidationResultDto validateResponse(ValidationInputDto inputDto) {
 				validationResultDto.setDescription("Validation of hash chain failed across multiple captures."
 						+ " Previous Hash for last request was {},"
 						+ " hash generated  by validator is {} and hash received is {}");
+				if ("".equals(previousHash)) {
+					previousHash = "''";
+				}
 				validationResultDto.setDescriptionKey(
-						"HASH_VALIDATOR_002" + AppConstants.ARGUMENTS_DELIMITER + previousHash == "" ? "''"
-								: previousHash + AppConstants.ARGUMENTS_SEPARATOR + errGeneratedHashValue
+						"HASH_VALIDATOR_002" + AppConstants.ARGUMENTS_DELIMITER + previousHash + AppConstants.ARGUMENTS_SEPARATOR + errGeneratedHashValue
 										+ AppConstants.ARGUMENTS_SEPARATOR + errHashReceived);
 				validationResultDto.setStatus(AppConstants.FAILURE);
 			}