update chopsticks and upgradeRestrictionSignal check #2985
Merged
+72
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2196 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2196 KB (+236 KB compared to latest release) Moonbeam runtime: 2140 KB (+216 KB compared to latest release) Moonriver runtime: 2132 KB (+208 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/bump-chopsticks +/- ##
======================================================
- Coverage 79.23% 79.18% -0.05%
Files 299 299
- Lines 87602 87226 -376
======================================================
- Hits 69405 69065 -340
- Misses 18197 18161 -36
|
pLabarta
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR fixes a false positive test error when
moonbeamandmoonriverruntimes get upgraded and the relay chain sends aupgrade restriction signal, disallowing future upgrades for a given cooldown. The test overrides the relay chain state by pass theupgrade restriction signalsince it is does not apply to what is being tested.