Test: Fix polkadot-decoding smoke test #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2188 KB (no changes) ✅ Moonbeam runtime: 2148 KB (no changes) ✅ Moonriver runtime: 2148 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2188 KB (+228 KB compared to latest release) Moonbeam runtime: 2148 KB (+224 KB compared to latest release) Moonriver runtime: 2148 KB (+224 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/test/smoke/improve-decoding +/- ##
====================================================================
Coverage 79.23% 79.23% 0.00%
Files 299 299
Lines 87602 87602
====================================================================
Hits 69405 69405
Misses 18197 18197
|
RomarQ
reviewed
Sep 30, 2024
RomarQ
requested changes
Sep 30, 2024
RomarQ
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds a retry for query responses which do not contain entries. From some experimentation, it seems that for the
accounts::assetsdata, random storage keys with high starting values such asfseem to be out of bounds for the existing records and fail when trying to read the first entry of the response.There are also changes to improve reproducing failing cases, mainly to avoid running the whole test and just try to query the module using the provided key override.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?