fix unfairness on proof size check estimation #2946
+116
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadkaouk
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2264 KB (no changes) ✅ Moonbeam runtime: 2240 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2264 KB (+304 KB compared to latest release) Moonbeam runtime: 2240 KB (+316 KB compared to latest release) Moonriver runtime: 2240 KB (+316 KB compared to latest release) |
librelois
reviewed
Sep 13, 2024
ahmadkaouk
added
D3-trivial
librelois
previously approved these changes
Sep 13, 2024
noandrea
changed the title
Coverage Report@@ Coverage Diff @@
## master ahmad-evm-native-transfer-test +/- ##
==================================================================
+ Coverage 79.18% 79.21% +0.03%
Files 299 299
- Lines 87673 87636 -37
==================================================================
Hits 69419 69419
- Misses 18254 18217 -37
|
RomarQ
approved these changes
Oct 3, 2024
RomarQ
reviewed
Oct 3, 2024
RomarQ
requested changes
Oct 3, 2024
librelois
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?