Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate weights per runtime #2939

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

TarekkMA
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Copy link
Contributor

github-actions bot commented Sep 10, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2184 KB (no changes) ✅

Moonbeam runtime: 2124 KB (no changes) ✅

Moonriver runtime: 2136 KB (no changes) ✅

Compared to latest release (runtime-3102)

Moonbase runtime: 2184 KB (+244 KB compared to latest release) ⚠️

Moonbeam runtime: 2124 KB (+224 KB compared to latest release) ⚠️

Moonriver runtime: 2136 KB (+236 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                       Coverage Diff                        @@
##           master   tarekkma/weights-per-runtime      +/-   ##
================================================================
- Coverage   80.93%                         75.95%   -4.98%     
+ Files         286                            352      +66     
+ Lines       81965                          88195    +6230     
================================================================
+ Hits        66331                          66985     +654     
+ Misses      15634                          21210    +5576     
Files Changed Coverage
/client/rpc/finality/src/lib.rs 88.14% (+6.89%) 🔼
/precompiles/proxy/src/tests.rs 96.68% (-0.09%) 🔽
/precompiles/relay-data-verifier/src/mock.rs 85.53% (-2.16%) 🔽

Coverage generated Wed Sep 11 08:05:50 UTC 2024

Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weights are not yet being generated for each runtime, benchmarks in pallet parachain_staking need to be updated to work with moonbeam and moonriver.

This PR should only be merged once all benchmarks work for all runtimes.

@TarekkMA TarekkMA marked this pull request as draft September 11, 2024 08:44
@TarekkMA TarekkMA added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants