Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Finalized and Safe Block tags #999

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Sep 26, 2024

Description

Add Finalized and Safe Block tags to the Standard Ethereum Json-RPC page.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert added the A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) label Sep 26, 2024
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the different tags are part of what is known as block parameter -> https://ethereum.org/en/developers/docs/apis/json-rpc/#default-block

Maybe we should rewrite this, many JSON RPC methods use block paremeters

@themacexpert themacexpert added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) and removed A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) labels Sep 26, 2024
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we have methods twice in the page. I would either remove them in the block tag section and then in the methods that support a block tag, I would add a reference to that section like you did for eth_getBlockByNumber

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the revisions, looks great!

@albertov19 albertov19 merged commit 0340fc0 into master Oct 2, 2024
1 check passed
@albertov19 albertov19 deleted the themacexpert/finalizedSafe branch October 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants