Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XCM tutorials with new multilocation and weight/proof size info #688

Merged
merged 14 commits into from
Jun 30, 2023

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Jun 28, 2023

Description

Updates the 3 XCM tutorials with the latest method for calculating the multi-location derivative account and updates outdated weight / proof size info. I suspect there are other places in the docs where I'll need to update this info as well, for scope this PR encompasses only the tutorials section.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

moonbeam-foundation/moonbeam-docs-cn#291
Jira for Translations: DR-1426

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for doing this. I've left a few comments on some standards, but it all looks good!

@themacexpert
Copy link
Contributor Author

Should be all set now!

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! ✨ LGTM!

@eshaben eshaben merged commit 05479f2 into master Jun 30, 2023
1 check passed
@eshaben eshaben deleted the themacexpert/xcm branch June 30, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants