Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #123: Fix schema issues in report_customsql_categories #125

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Issue #123: Fix schema issues in report_customsql_categories #125

wants to merge 20 commits into from

Conversation

jnlar
Copy link

@jnlar jnlar commented Dec 22, 2022

Resolves issue: #123

-------------------------------------------------------------------------------
report_customsql_categories
 * column 'name' should be NOT NULL (C)
 * column 'name' has default 'Miscellaneous', expected 'NULL' (C)
-------------------------------------------------------------------------------

Added upgrade block that:

  • Changes nullability of field name on table report_customsql_categories to not null
  • Changes the default of field name on table report_customsql_categories to drop it.

Tim Price and others added 20 commits October 13, 2015 14:57
Add new custom directory option to store copy of report on filesystem
d7a6737
Refactoring update to address Tim's feedback
40e8fe7
Allow no directory to be set
af78630
Check file exists before attempting copy
d98bbe5
Fixing file exists checks, allow to work if no records returned
1148946
Revert "Check file exists before attempting copy"
83aeb3e 
This reverts commit d98bbe5.
Merge branch 'master' into originmaster
da69d58
@danmarsden
Fix moodleou#114 - return empty csv file (with headers) when no results.
cdc9032
@danmarsden
Bump pg version in github action config.
485a8e7
@danmarsden
Fix phpdocs and simplify check for empty row.
b2447dd
@danmarsden
Try a simple behat test
4862f67
@jnlar
Fix moodleou#123: Fix schema issues in report_customsql_categories
882afea
@keevan
Merge pull request #1 from catalyst/issue123-categories-schema
7b44f4a 
Fix moodleou#123: Fix schema issues in report_customsql_categories
@gbarat87
WR410672 Merge with the github project
5ef87f9
@gbarat87
Merge branch 'fix114' of github.com:danmarsden/moodle-report_customsq…
50e1d5d 
…l into WR410672-add-dan-fix
@brendanheywood
Merge branch 'WR410672-fix-report-sql' into 'catalyst-main'
00986e2 
WR410672 new branch with update from the github moodle-report_customsql

See merge request elearning/mdl-report_customsql!7
@brendanheywood
Merge branch 'WR410672-add-dan-fix' into 'main-catalyst'
8a226de 
Wr410672 add dan fix

See merge request elearning/mdl-report_customsql!9
@jay-oswald
WR-416501 fix privacy test
40c30ec
@jay-oswald
Merge branch 'WR-416501-fix-privacy-test' into 'main-catalyst'
626efc3 
WR-416501 fix privacy test

See merge request elearning/mdl-report_customsql!10
@jay-oswald
Merge pull request #2 from catalyst/main-catalyst-updated
98fe1d7 
Main catalyst updated
@timhunt
Copy link
Member

timhunt commented Dec 13, 2023

Sorry for not looking for this for so long.

However, not helpful to have a branches of 20+ commits that claims to just fix one bug.

Please rebase on latest main branch and I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jnlar @timhunt @danmarsden @keevan @gbarat87 @brendanheywood @jay-oswald